-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapids_cpm_bs_thread_pool() #651
Add rapids_cpm_bs_thread_pool() #651
Conversation
Add a function to download and export bshoshany/thread-pool.
e2ee60a
to
e1e725a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
We are missing the documentation api updates ( https://github.com/rapidsai/rapids-cmake/blob/branch-24.08/docs/api.rst ) and the formatting rules ( https://github.com/rapidsai/rapids-cmake/blob/branch-24.08/cmake-format-rapids-cmake.json )
Done |
Noticed while working on rapidsai#651.
It would be great to have a kvikio PR that leverages this work so we can validate we didn't miss anything |
rapidsai/kvikio#408 was already working on this, I'll update it to use this PR instead. |
Updated rapidsai/kvikio#408 to use this PR. |
Also opened rapidsai/cudf#16360 to test this PR. |
Compiling twice fails in KvikIO now:
|
This is due to how rapidsai/kvikio#408 changes are structured. The setting of the |
Fixed the variable issue at rapidsai/kvikio#408. |
Approving, presuming that the cudf and kvikio CI won't show any issues |
rapidsai/kvikio#408 is now passing CI |
rapidsai/cudf#16360 is passing CI too. Ready to merge? |
/merge |
Noticed while working on #651. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #652
Add a function to download and export bshoshany/thread-pool.
Description
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)