Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cmake_support_conda_env adds -O0 to debug compile lines #635

Merged
merged 1 commit into from
Jun 27, 2024
Merged

rapids_cmake_support_conda_env adds -O0 to debug compile lines #635

merged 1 commit into from
Jun 27, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

When building in a conda env the default CXXFLAGS, CFLAGS, etc will inject -O2 on the compile line making Debug bugs significantly less useful. rapids_cmake_support_conda_env now injects a -O0 to override the -O2 set by conda to make debug builds usable.

Fixes #634

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard requested a review from a team as a code owner June 26, 2024 17:00
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jun 26, 2024
@robertmaynard robertmaynard force-pushed the fea/support_conda-enable-debug-config branch from 6c0e55d to 7aa37ba Compare June 26, 2024 19:14
harrism
harrism approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fa6d25b into rapidsai:branch-24.08 Jun 27, 2024
15 of 16 checks passed
@robertmaynard robertmaynard deleted the fea/support_conda-enable-debug-config branch June 27, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] rapids_cmake_support_conda_env should add -O0 to debug compile lines
3 participants
@robertmaynard @harrism @vyasr