Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuco git tag to fetch new multiset data structure #628

Merged
merged 18 commits into from
Jul 10, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Jun 5, 2024

Description

This PR bumps the cuco version to fetch the new multiset data structure.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel
Copy link
Member Author

PointKernel commented Jul 1, 2024

@PointKernel PointKernel marked this pull request as ready for review July 1, 2024 23:36
@PointKernel PointKernel changed the title [DO NOT MERGE] Update cuco git tag to fetch new multiset data structure Update cuco git tag to fetch new multiset data structure Jul 1, 2024
@PointKernel PointKernel requested a review from a team as a code owner July 3, 2024 15:38
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jul 3, 2024
@PointKernel
Copy link
Member Author

Using a different cuco git tag seems to solve the CI failures.

Let me put this as a draft PR to test the new cuco git tag against relevant RAPIDS projects.

DO NOT MERGE

@PointKernel PointKernel marked this pull request as draft July 8, 2024 19:41
@PointKernel
Copy link
Member Author

I wanted to fetch the latest SHA of cuco since it includes a bug fix but that git tag failed the CI again. @robertmaynard can you please take a look?

@robertmaynard
Copy link
Contributor

Ci is all passing now.

@robertmaynard robertmaynard marked this pull request as ready for review July 9, 2024 19:33
@PointKernel
Copy link
Member Author

cudf CI passed but some of the raft and cugraph CI tasks are still failing. I will ping here once all CI passes.

@PointKernel
Copy link
Member Author

All repos passed. This is ready to merge.

@bdice
Copy link
Contributor

bdice commented Jul 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit b6127eb into rapidsai:branch-24.08 Jul 10, 2024
15 checks passed
@PointKernel PointKernel deleted the cuco-equal-update branch July 10, 2024 17:02
trxcllnt added a commit to trxcllnt/cudf that referenced this pull request Jul 11, 2024
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Jul 11, 2024
This PR removes the cuDF `cuco_noexcept.diff` patch since it no longer applies after rapidsai/rapids-cmake#628.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

URL: #16254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants