Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_cpm_gtest adds support for BUILD_STATIC #576

Merged
merged 1 commit into from
Apr 9, 2024
Merged

rapids_cpm_gtest adds support for BUILD_STATIC #576

merged 1 commit into from
Apr 9, 2024

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Apr 8, 2024 •
edited by bdice
Loading

Description

Extends the BUILD_STATIC option from GBench and NVBench to GTest. This will allow RAPIDS projects to package tests without any testing dependency libraries.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Apr 8, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner April 8, 2024 20:23
@robertmaynard robertmaynard force-pushed the fea/support_static_builds_of_gtest branch from 729430d to 06f0cdf Compare April 8, 2024 20:23
bdice
bdice approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Please open an issue (rapidsai/build-planning or this repo) where we can track migration of all RAPIDS packages to use static benchmarks/tests, if one doesn't exist yet.

@robertmaynard
Copy link
Contributor Author

Looks good to me. Thanks! Please open an issue (rapidsai/build-planning or this repo) where we can track migration of all RAPIDS packages to use static benchmarks/tests, if one doesn't exist yet.

rapidsai/build-planning#32

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c0da632 into rapidsai:branch-24.06 Apr 9, 2024
15 checks passed
@robertmaynard robertmaynard deleted the fea/support_static_builds_of_gtest branch April 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice