Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nvcomp targets #496

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Add missing nvcomp targets #496

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5da708c
Add more global targets
vyasr Dec 2, 2023
951ed11
Add targets to the main find command
vyasr Dec 4, 2023
3aec63d
Update docs
vyasr Dec 4, 2023
f7d48b0
Split up targets
vyasr Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions rapids-cmake/cpm/nvcomp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ across all RAPIDS projects.
Result Targets
^^^^^^^^^^^^^^
nvcomp::nvcomp target will be created
nvcomp::nvcomp_gdeflate target will be created
nvcomp::nvcomp_bitcomp target will be created

Result Variables
^^^^^^^^^^^^^^^^
Expand Down Expand Up @@ -91,8 +93,9 @@ function(rapids_cpm_nvcomp)
# first search locally if `rapids_cmake_always_download` is false
if(NOT rapids_cmake_always_download)
include("${rapids-cmake-dir}/find/package.cmake")
rapids_find_package(nvcomp ${version} GLOBAL_TARGETS nvcomp::nvcomp ${_RAPIDS_EXPORT_ARGUMENTS}
FIND_ARGS QUIET)
rapids_find_package(nvcomp ${version}
GLOBAL_TARGETS nvcomp::nvcomp nvcomp::nvcomp_gdeflate nvcomp::nvcomp_bitcomp
${_RAPIDS_EXPORT_ARGUMENTS} FIND_ARGS QUIET)
if(nvcomp_FOUND)
# report where nvcomp was found
message(STATUS "Found nvcomp: ${nvcomp_DIR} (found version ${nvcomp_VERSION})")
Expand Down Expand Up @@ -136,7 +139,7 @@ function(rapids_cpm_nvcomp)

include("${rapids-cmake-dir}/cpm/find.cmake")
rapids_cpm_find(nvcomp ${version} ${_RAPIDS_UNPARSED_ARGUMENTS}
GLOBAL_TARGETS nvcomp::nvcomp
GLOBAL_TARGETS nvcomp::nvcomp nvcomp::nvcomp_gdeflate nvcomp::nvcomp_bitcomp
CPM_ARGS
GIT_REPOSITORY ${repository}
GIT_TAG ${tag}
Expand All @@ -153,6 +156,12 @@ function(rapids_cpm_nvcomp)
if(NOT TARGET nvcomp::nvcomp AND TARGET nvcomp)
add_library(nvcomp::nvcomp ALIAS nvcomp)
endif()
if(NOT TARGET nvcomp::nvcomp_gdeflate AND TARGET nvcomp_gdeflate)
add_library(nvcomp::nvcomp_gdeflate ALIAS nvcomp_gdeflate)
vyasr marked this conversation as resolved.
Show resolved Hide resolved
endif()
if(NOT TARGET nvcomp::nvcomp_bitcomp AND TARGET nvcomp_bitcomp)
add_library(nvcomp::nvcomp_bitcomp ALIAS nvcomp_bitcomp)
endif()

# Propagate up variables that CPMFindPackage provide
set(nvcomp_SOURCE_DIR "${nvcomp_SOURCE_DIR}" PARENT_SCOPE)
Expand Down