Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload conda packages for rapids_core_dependencies. #414

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 17, 2023

Description

This PR uploads conda packages as CI artifacts for rapids_core_dependencies.

I also aligned some bits of rapids-cmake's testing scripts/workflows with other RAPIDS repos.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner May 17, 2023 19:11
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 17, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these builds/tests need to occur nightly?

If so, we'll need to add rapids-cmake to the nightly pipeline below:

@vyasr vyasr changed the base branch from branch-23.06 to branch-23.08 June 1, 2023 21:21
@vyasr
Copy link
Contributor

vyasr commented Jun 1, 2023

I don't have a strong opinion on whether we run the tests nightly, but since we have the infra in place I think we might as well.

@bdice
Copy link
Contributor Author

bdice commented Jun 1, 2023

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants