Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuco git tag to support cuco::static_set #407

Merged
merged 3 commits into from
May 11, 2023

Conversation

PointKernel
Copy link
Member

Description

This PR fetches the latest cuco git tag which supports cuco::static_set.

rapidsai/cudf#13261 confirmed the update won't break cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@robertmaynard
Copy link
Contributor

This looks good, will want to test.

While I do that, can you bump the rapids-cmake version used by cuCollections to 23.06?

@PointKernel
Copy link
Member Author

Opened NVIDIA/cuCollections#302

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 5, 2023
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, would like to move the SHA1 once NVIDIA/cuCollections#302 has been merged.

@PointKernel
Copy link
Member Author

cuco SHA updated.

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 95f9210 into rapidsai:branch-23.06 May 11, 2023
rapids-bot bot pushed a commit that referenced this pull request May 12, 2023
This is a follow-up PR of #407. It fetches the latest cuco that fixes several bugs uncovered during libcudf integration.

rapidsai/cudf#13343 verified this won't break cudf.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #412
@PointKernel PointKernel deleted the cuco-set-tag branch February 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants