Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpm: always_download now considers patches json entry #353

Conversation

robertmaynard
Copy link
Contributor

Description

Now we only mark always_download as true when the override is changing the git_tag, git_url, and patches.

Corrects issues where projects like libcudf would add an override for projects with just patches listed and expect
always_download to be true.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

Now we only mark always_download as true when the override is changing the git_tag, git_url, and patches.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 25, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner January 25, 2023 16:58
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fb4dd44 into rapidsai:branch-23.02 Jan 25, 2023
@robertmaynard robertmaynard deleted the bug/override_with_patches_entry_means_always_download branch January 25, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant