Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libcudacxx 1.9.1 to have a version >= CUDA Toolkit 12 #343

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

libcudacxx 1.9.1 fixes the issues found when merging: #332

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 19, 2023
@robertmaynard robertmaynard added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team labels Jan 19, 2023
@robertmaynard
Copy link
Contributor Author

Can't merge due to new regression in libcudacxx 1.9.1: rapidsai/cudf#12581

@robertmaynard robertmaynard force-pushed the fea/update_libcudacxx_ver branch from ecb97cb to 0c05e4c Compare January 19, 2023 18:49
@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Jan 19, 2023
@robertmaynard
Copy link
Contributor Author

Can't merge due to new regression in libcudacxx 1.9.1: rapidsai/cudf#12581

libcudacxx branch/1.9.1 has been updated to correct the new compile failures. So this is valid again for 22.03

@robertmaynard
Copy link
Contributor Author

CI has no failures with libcudacxx 1.9.1 ( rapidsai/cudf#12581 ) so merging

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5c6e4d4 into rapidsai:branch-23.02 Jan 20, 2023
@robertmaynard robertmaynard deleted the fea/update_libcudacxx_ver branch January 20, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant