Default Cython module RUNPATH to $ORIGIN and return the list of created targets #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
force-pushed
the
fix/cython_rpath_origin
branch
from
f67d648 to
40fabfe
Compare
vyasr
force-pushed
the
fix/cython_rpath_origin
branch
from
e45413b to
38779ec
Compare
vyasr
changed the title
|
@robertmaynard I ended up choosing an approach that balances the simplicity of setting a default RPATH with giving users the flexibility to easily override it if they want. |
robertmaynard
approved these changes
May 13, 2022
|
@robertmaynard done. I've requested write access to this repo, but until I get it you will also need to update the labels before we can merge. |
robertmaynard
added
feature request
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the default RPATH for Cython-generated Python extension modules to $ORIGIN so that they will default to finding libraries within the same directory. If rapids-cmake users want to enforce a different directory layout in their library, they are responsible for overriding the RPATHs themselves. To facilitate this as well as other potential downstream modifications,
rapids_cython_create_modulesnow also returns the set of created targets in theRAPIDS_CYTHON_CREATED_TARGETSvariable.