Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update to GTest 1.13 #400

Closed
robertmaynard opened this issue Apr 17, 2023 · 0 comments · Fixed by #401
Closed

[FEA] Update to GTest 1.13 #400

robertmaynard opened this issue Apr 17, 2023 · 0 comments · Fixed by #401
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

RAPIDS is using GTest 1.10 which requires work-arounds due to limitations built into having to support C++03.
GTest 1.13 requires a C++14 compiler so we can remove work-arounds.

Note:
That this will require an audit of libraft, libcugraph, librmm, and libcuml to verify that any custom printer functions are in the correct namespace due to the more constrained ADL rules that GTest 1.11+ uses.
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 17, 2023
@robertmaynard robertmaynard mentioned this issue Apr 17, 2023
Merged
4 tasks
@rapids-bot rapids-bot bot closed this as completed in #401 Apr 24, 2023
rapids-bot bot pushed a commit that referenced this issue Apr 24, 2023
@robertmaynard
Upgrade GTest version to 1.13 (#401)
6a713e4 
Upgrade GTest 
Fixes #400

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #401
@isVoid isVoid mentioned this issue May 8, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue May 9, 2023
@isVoid
Bump Gtest version following Rapids-cmake change (#1126)
6e56d13 
Following Rapids-cmake bump to gtest 1.13.0 rapidsai/rapids-cmake#400, this PR implements some custom out stream operator for more constrained ADL rules that 1.11+ uses.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)

URL: #1126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade GTest version to 1.13 robertmaynard/rapids-cmake
1 participant
@robertmaynard