Add disable-cuda option
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we don't want to append a -cu* suffix to the package name or get CUDA-version-specific dependencies. Add an option to disable this. This option supplants require-cuda, so get rid of it too.
jameslamb
approved these changes
May 10, 2024
There was a problem hiding this comment.
Looks good to me! I left 2 small suggestions but neither of them needs to block this.
I'd also support bumping the version and immediately releasing this. At this point where nothing external-facing is using rapids-build-backend yet, releases are cheap and low-risk.
Selfishly, I'd love to have this stricter behavior around CUDA out in packages for testing rapidsai/cudf#15245.
vyasr
approved these changes
May 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we don't want to append a
-cu*suffix to the package name or get CUDA-version-specific dependencies. Add an option to disable this. This option supplantsrequire-cuda, so get rid of it too.