Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'disable-cuda-suffix' config setting #29

Merged
merged 1 commit into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ It currently support `scikit-build-core` and `setuptools` as the wrapped builder
The package's primary purpose is to automate the various bits of preprocessing that are typically done to RAPIDS package metadata prior to publishing packages.
This includes the following notable changes:
- Running [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator) to get the dependencies for the CUDA version and architecture.
- Modifying the package name to include CUDA suffixes.
- Modifying the package name to include a CUDA suffix (e.g. `"rmm" -> "rmm-cu11"`)
- Updating the git commit embedded in the importable package.

Since some of these modifications are only desirable in certain scenarios (wheel vs conda builds vs editable installs), all of these functions are customizable via the project's configuration in pyproject.toml.
Expand All @@ -20,7 +20,6 @@ Any option without a default is required.
| `build-backend` | The wrapped build backend (e.g. `setuptools.build_meta`) | string | | N |
| `commit-file` | The file in which to write the git commit hash | string | "" (No file) | N |
| `dependencies-file` | The path to the `dependencies.yaml` file to use | string | "dependencies.yaml" | Y |
| `disable-cuda-suffix` | If true, don't try to write CUDA suffixes | bool | false | Y |
| `matrix-entry` | A `;`-separated list of `=`-delimited key/value pairs | string | "" | Y |
| `require-cuda` | If false, builds will succeed even if nvcc is not available | bool | true | Y |
| `requires` | List of build requirements (in addition to `build-system.requires`) | list[str] | [] | N |
Expand Down
1 change: 0 additions & 1 deletion rapids_build_backend/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class Config:
"build-backend": (None, False),
"commit-file": ("", False),
"dependencies-file": ("dependencies.yaml", True),
"disable-cuda-suffix": (False, True),
"matrix-entry": ("", True),
"require-cuda": (True, True),
"requires": (lambda: [], False),
Expand Down
7 changes: 0 additions & 7 deletions tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ def setup_config_project(tmp_path, flag, config_value):
[
("commit-file", '"pkg/_version.py"', "pkg/_version.py"),
("commit-file", None, ""),
("disable-cuda-suffix", "true", True),
("disable-cuda-suffix", "false", False),
("disable-cuda-suffix", None, False),
("require-cuda", "true", True),
("require-cuda", "false", False),
("require-cuda", None, True),
Expand All @@ -43,8 +40,6 @@ def test_config(tmp_path, flag, config_value, expected):
@pytest.mark.parametrize(
"flag, config_value, expected",
[
("disable-cuda-suffix", "true", True),
("disable-cuda-suffix", "false", False),
("require-cuda", "true", True),
("require-cuda", "false", False),
],
Expand All @@ -68,8 +63,6 @@ def test_config_env_var(tmp_path, flag, config_value, expected):
@pytest.mark.parametrize(
"flag, config_value, expected",
[
("disable-cuda-suffix", "true", True),
("disable-cuda-suffix", "false", False),
("require-cuda", "true", True),
("require-cuda", "false", False),
],
Expand Down