Fix warning when dependencies.yaml doesn't exist (#35)

The warning was accidentally being issued with a tuple instead of a string. Fix.
rapidsai · May 17, 2024 · ca51a32 · ca51a32
1 parent 1e918c6
commit ca51a32
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 17 deletions.
diff --git a/rapids_build_backend/impls.py b/rapids_build_backend/impls.py
@@ -151,8 +151,8 @@ def _edit_pyproject(config):
     except FileNotFoundError:
         msg = (
             f"File not found: '{config.dependencies_file}'. If you want "
-            "rapids-build-backend to consider dependencies from a dependencies file, ",
-            "supply an existing file via config setting 'dependencies-file'.",
+            "rapids-build-backend to consider dependencies from a dependencies file, "
+            "supply an existing file via config setting 'dependencies-file'."
         )
         warnings.warn(msg, stacklevel=2)
         parsed_config = None

diff --git a/tests/test_impls.py b/tests/test_impls.py
@@ -263,9 +263,9 @@ def test_edit_pyproject(
             "rapids_build_backend.impls._get_cuda_suffix",
             _get_cuda_suffix.__wrapped__,
         ):
-            with _edit_pyproject(config):
-                with open("pyproject.toml") as f:
-                    if write_dependencies_file:
+            if write_dependencies_file:
+                with _edit_pyproject(config):
+                    with open("pyproject.toml") as f:
                         assert f.read() == dedent(
                             f"""\
                             [project]
@@ -288,19 +288,30 @@ def test_edit_pyproject(
                             """`rapids-dependency-file-generator`.
                             """
                         )
-                    else:
-                        assert f.read() == dedent(
-                            f"""\
-                            [project]
-                            name = "test-project{cuda_suffix}"
-                            dependencies = []
+                    with open(".pyproject.toml.rapids-build-backend.bak") as f:
+                        assert f.read() == original_contents
+            else:
+                with pytest.warns(
+                    UserWarning,
+                    match=rf"^File not found: '{dependencies_file}'\. If you want "
+                    "rapids-build-backend to consider dependencies from a dependencies "
+                    "file, supply an existing file via config setting "
+                    r"'dependencies-file'\.$",
+                ):
+                    with _edit_pyproject(config):
+                        with open("pyproject.toml") as f:
+                            assert f.read() == dedent(
+                                f"""\
+                                [project]
+                                name = "test-project{cuda_suffix}"
+                                dependencies = []
 
-                            [build-system]
-                            requires = []
-                            """
-                        )
-                with open(".pyproject.toml.rapids-build-backend.bak") as f:
-                    assert f.read() == original_contents
+                                [build-system]
+                                requires = []
+                                """
+                            )
+                        with open(".pyproject.toml.rapids-build-backend.bak") as f:
+                            assert f.read() == original_contents
 
         with open("pyproject.toml") as f:
             assert f.read() == original_contents