Provide CPU/GPU interoperable device_id type #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide an enum class used to distinguish among various memory types. This allows decoupling of the concept of memory type from a specific mdspan accessor policy and ensures that templates receive only a logically-consistent memory type.
As a follow-up to rapidsai#984 which introduces a memory_type enum, this PR introduces a device_type enum with similar justifications.
Co-authored-by: Rajesh Gandham <[email protected]>
wphicks
added
feature request
|
rerun tests |
|
Looks like a network issue killed the last run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #985 and #986, this PR provides a
device_idtype templated ondevice_typewhich can be used in CPU/GPU interoperable APIs which must accept a device ID. The primary purpose of this type is to allow for API compatibility and code reuse between CPU and GPU implementations of the same functionality.