Adding optional handle to each public API function (along with example) #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
dantegd
approved these changes
Oct 24, 2022
| @@ -88,7 +91,15 @@ def fused_l2_nn_argmin(X, Y, output, sqrt=True): | |||
| dtype=cp.float32) | |||
| output = cp.empty((n_samples, 1), dtype=cp.int32) | |||
|
|
|||
| fused_l2_nn_argmin(in1, in2, output) | |||
| # A single RAFT handle can optionally be reused across | |||
There was a problem hiding this comment.
Quick comment: we might want to adopt a docstring generator like the one in cuML for common ones like this
There was a problem hiding this comment.
Yes I think centralizing this is a great idea. I'll start looking into the doc function in cuml
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #946