Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for
raft::matrix
#937Add tests for
raft::matrix
#937Changes from all commits
d833a85
2630c30
4d21b8b
1123262
5a0a371
50e9bf2
9a6b6e3
e24e850
bf29eaf
cae83e7
f07019a
a2011d4
8409a24
ac6c72b
91bc8e1
5349b4b
2de4cf7
ddc8a52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of making this an enum but I suggest we find a more descriptive name for this.
Apply
just brings to mind several different possibilities, none of which immediately said "oh broadcast the vector across the rows" to me.Maybe something like
BroadcastType
? (That's just off the top of my head, im sure there are better names)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe even
VectorBroadcast::ALONG_ROWS
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized this was already defined in
linalg
(prior to this PR). I think we can keep this name for now and rename this in a future PR.