[DO NOT MERGE] updated clang to v11.0.0 #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
Tagging @codereport , JFYI |
|
This PR has been marked stale due to no recent activity in the past 30d. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be marked rotten if there is no activity in the next 60d. |
|
This PR has been marked rotten due to no recent activity in the past 90d. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. |
|
Closing this PR for now. @codereport in case you are able to make progress on this for other RAPIDS libraries, let me know and I too can restart this effort. |
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
* Remove the devcontainer when the VSCode window closes * Adds a descriptive name to the running container: ```shell $ docker ps -a CONTAINER ID IMAGE ... NAMES 0dbb364fe544 vsc-cuvs-... ... rapids-cuvs-24.06-cuda12.2-conda $ docker rm -f rapids-cuvs-24.06-cuda12.2-conda ``` Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Ben Frederickson (https://github.com/benfred) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai/cuvs#89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the one filed for cuML here: rapidsai/cuml#3121, this PR tries to show the set of changes especially with clang-format, after updating clang to 11.0.0. As can be seen from the diff's, there's almost no change in clang-format fixes by upgrading to 11.0.0 from 8.0.1. So, it should be safe to update clang version in our conda env's in RAPIDS to 11.0.0.