Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Include knn.cuh in knn.cu benchmark source for finding brute_force_knn #855

Merged

Conversation

teju85
Copy link
Member

@teju85 teju85 commented Sep 28, 2022

Current issue is that if you try to build only the benchmark code by doing ./build.sh bench, the file cpp/bench/spatial/knn.cu fails to compile with the following error:

...
./cpp/bench/spatial/knn.cu(177): error: namespace "raft::spatial::knn" has no member "brute_force_knn"
          detected during:
            instantiation of "void raft::bench::spatial::knn<ValT, IdxT, ImplT>::run_benchmark(benchmark::State &) [with ValT=float, IdxT=int64_t, ImplT=raft::bench::spa$ial::brute_force_knn<float, int64_t>]"
...

The issue is that this file doesn't include knn.cuh (Courtesy: @achirkin). This PR fixes the error.

@teju85 teju85 added bug Something isn't working non-breaking Non-breaking change cpp labels Sep 28, 2022
@teju85 teju85 requested a review from a team as a code owner September 28, 2022 10:43
@cjnolet
Copy link
Member

cjnolet commented Sep 28, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Sep 29, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Sep 29, 2022

@teju85 this is weird and I'm not sure why CI keeps timing out on this PR. I thought there was somehting wrong w/ CI at first but it doesn't seem to time out like this on the other PRs. maybe there's another template we need to consider instantiating here?

@github-actions github-actions bot removed the cpp label Sep 30, 2022
@cjnolet
Copy link
Member

cjnolet commented Sep 30, 2022

@teju85 can you try also including raft/distance/specializations.cuh inside raft/spatial/knn/specializations.cuh? I think the knn specializations, especially the fused l2 knn, implicitly assume the needed distance specializations have been compiled already.

@cjnolet cjnolet force-pushed the bug-ext-fix-knn-bench-compile branch from 61a0166 to 25ebd2c Compare September 30, 2022 19:52
@cjnolet cjnolet requested a review from a team as a code owner September 30, 2022 19:52
@github-actions github-actions bot added CMake and removed CMake labels Sep 30, 2022
@cjnolet cjnolet force-pushed the bug-ext-fix-knn-bench-compile branch from a7113c4 to 5f409f6 Compare October 2, 2022 02:42
@github-actions github-actions bot removed the CMake label Oct 2, 2022
@cjnolet
Copy link
Member

cjnolet commented Oct 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit da9da83 into rapidsai:branch-22.10 Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants