Mdspanifying (currently tested) raft::matrix
#846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoemmen
reviewed
Sep 30, 2022
divyegala
reviewed
Oct 1, 2022
divyegala
approved these changes
Oct 2, 2022
| /** | ||
| * @brief Overload of `sort_keys_per_row` to help the | ||
| * compiler find the above overload, in case users pass in | ||
| * `std::nullopt` for one or both of the optional arguments. |
There was a problem hiding this comment.
I thought this overload was only needed when there are two optional arguments? @mhoemmen
| * @param[in] scalar scalar value to fill matrix elements | ||
| */ | ||
| template <typename math_t, typename idx_t, typename layout> | ||
| void fill(const raft::handle_t& handle, |
There was a problem hiding this comment.
We should probably have another element wise function for every possible mdspan shape
|
I mentioned this offline but it's still unclear to me what exactly the final state of matrix vs linalg should look like after consolidation. For example, I'm not completely convinced that these element wise ops should be in linalg because they aren't linear algebra, yet because they are element wise ops they might not necessarily belong in the matrix namespace either. We need to think about it a bit more, I think. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.