[FEA] Statically link all CUDA toolkit libraries #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
3 - Ready for Review
improvement
cjnolet
reviewed
Sep 2, 2022
| @@ -66,7 +68,22 @@ function(find_and_configure_faiss) | |||
| rapids_export_find_package_root(BUILD faiss [=[${CMAKE_CURRENT_LIST_DIR}]=] raft-nn-lib-exports) | |||
| endfunction() | |||
|
|
|||
| if(NOT RAFT_FAISS_GIT_TAG) | |||
| # TODO: Remove this once faiss supports FAISS_USE_CUDA_TOOLKIT_STATIC | |||
There was a problem hiding this comment.
Is the plan to wait for this before we merge this PR? Or should we create a RAFT issue just to make sure it stays on our radar?
There was a problem hiding this comment.
@cjnolet it's up to you -- I based this branch from the commit sha here. If pointing at my fork is fine with you, then great. Otherwise, it might be worth forking faiss into rapidsai and cherry-picking my commit.
cjnolet
approved these changes
Sep 8, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures RAFT statically links all the CUDA toolkit libraries (not just
cudart) if a user enablesCUDA_STATIC_RUNTIME.