Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adj_to_csr_kernel #785

Merged

Conversation

ahendriksen
Copy link
Contributor

This PR adds launch bounds to adj_to_csr kernel, making it forward compatible with future architectures.

@ahendriksen ahendriksen requested a review from a team as a code owner August 9, 2022 12:03
@github-actions github-actions bot added the cpp label Aug 9, 2022
@ahendriksen ahendriksen force-pushed the enh-launch-bounds-adj-to-csr branch from c546ff5 to 152895c Compare August 9, 2022 12:05
@ahendriksen ahendriksen changed the base branch from branch-22.10 to branch-22.08 August 9, 2022 12:05
@cjnolet cjnolet added the bug Something isn't working label Aug 9, 2022
@ahendriksen ahendriksen force-pushed the enh-launch-bounds-adj-to-csr branch from 152895c to fcee1c3 Compare August 9, 2022 14:39
Also: reduce threads per block from 1024 to 512. This improves
performance slightly on upcoming compute architectures.
@cjnolet cjnolet changed the base branch from branch-22.08 to branch-22.10 August 9, 2022 20:09
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahendriksen for the PR, it looks good to me!

@wphicks
Copy link
Contributor

wphicks commented Aug 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c9cce72 into rapidsai:branch-22.10 Aug 11, 2022
@ahendriksen ahendriksen deleted the enh-launch-bounds-adj-to-csr branch March 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants