Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type punning from TxN_t #781

Merged
merged 11 commits into from
Aug 23, 2022

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Aug 5, 2022

Avoid undefined behavior related to accessing inactive union members in TxN_t

@github-actions github-actions bot added the cpp label Aug 5, 2022
@wphicks wphicks added bug Something isn't working breaking Breaking change labels Aug 5, 2022
@wphicks wphicks changed the base branch from branch-22.08 to branch-22.10 August 8, 2022 15:18
@wphicks wphicks marked this pull request as ready for review August 17, 2022 14:37
@wphicks wphicks requested a review from a team as a code owner August 17, 2022 14:37
@wphicks
Copy link
Contributor Author

wphicks commented Aug 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f891dc2 into rapidsai:branch-22.10 Aug 23, 2022
rapids-bot bot pushed a commit that referenced this pull request Aug 25, 2022
The recent removal of the union-based type punning in #781 caused misaligned access in some cases. This PR returns the alignment to the data type.

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - William Hicks (https://github.com/wphicks)

URL: #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review breaking Breaking change bug Something isn't working cpp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants