Restrict the use of [[no_unique_address]] to CXX 20 only.
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
added
bug
mhoemmen
approved these changes
Jul 28, 2022
| (!defined(__NVCC__) || ((__CUDACC_VER_MAJOR__ > 11) && (__CUDACC_VER_MINOR__ > 5))) | ||
| # if (__has_cpp_attribute(no_unique_address) >= 201803L) && !defined(_MDSPAN_COMPILER_MSVC) | ||
| #if !defined(_MDSPAN_USE_ATTRIBUTE_NO_UNIQUE_ADDRESS) | ||
| # if MDSPAN_HAS_CXX_20 && (__has_cpp_attribute(no_unique_address) >= 201803L) |
There was a problem hiding this comment.
Thanks for the proposed fix! This looks reasonable. Users can always turn off the feature if their compiler doesn't support it. Are you able to test with MDSPAN_HAS_CXX_20?
There was a problem hiding this comment.
doesn't that mean you always turn it off for NVCC since nvcc does not support C++20?
|
I think we should merge this, but I want to make sure if we have to merge in updates from Kokkos in the future then this won't be reverted if they haven't made the same updates by then. Can we do a quick update of our fork of Kokkos/mdspan and apply this change there too? |
cjnolet
approved these changes
Jul 28, 2022
|
@gpucibot merge |
|
I will open a PR upstream tomorrow. |
|
Thankis again for the fix @trivialfis (and @achirkin)! |
|
Thanks @trivialfis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #740 .
Found by @achirkin , the size of
mappingis non-deterministic. This is caused by the macro definition around whetherno_unique_addressis supported with nvcc. This PR uses the standard cpp version to define the macro regardless of the compiler being used.