Move cmake to the build section. #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
improvement
msadang
approved these changes
Jul 28, 2022
raydouglass
reviewed
Jul 28, 2022
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # raft 22.10.00 (Date TBD) | |||
There was a problem hiding this comment.
Looks like you branched from branch-22.10 but are targeting branch-22.08. Can you fix this?
cjnolet
force-pushed
the
fix/conda_meta_cmake
branch
from
7e5a459 to
2fecac6
Compare
cjnolet
approved these changes
Jul 28, 2022
|
Looks like an intermittent failing ANN ivf flat gtest. |
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a CLI tool CMake belongs in the build section and shouldn't need to be present in the host requirements.