[FIX] Update dask-cuda versions in dev env ymls
#710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
3 - Ready for Review
improvement
cjnolet
approved these changes
Jun 14, 2022
…envs-dask-cuda-version
|
rerun tests |
1 similar comment
|
rerun tests |
bdice
reviewed
Jun 16, 2022
| @@ -15,7 +15,7 @@ dependencies: | |||
| - rapids-notebook-env=22.02.* | |||
| - rapids-doc-env=22.02.* | |||
| - rmm=22.02.* | |||
| - dask-cuda=22.02.* | |||
| - dask-cuda=22.08. | |||
There was a problem hiding this comment.
To match other repos' pinnings (and other pinnings in this file), does this need a trailing *?
Suggested change
| - dask-cuda=22.08. | |
| - dask-cuda=22.08.* |
| @@ -15,7 +15,7 @@ dependencies: | |||
| - rapids-notebook-env=22.02.* | |||
| - rapids-doc-env=22.02.* | |||
| - rmm=22.02.* | |||
| - dask-cuda=22.02.* | |||
| - dask-cuda=22.08. | |||
There was a problem hiding this comment.
Suggested change
| - dask-cuda=22.08. | |
| - dask-cuda=22.08.* |
| @@ -15,7 +15,7 @@ dependencies: | |||
| - rapids-notebook-env=22.02.* | |||
| - rapids-doc-env=22.02.* | |||
| - rmm=22.02.* | |||
| - dask-cuda=22.02.* | |||
| - dask-cuda=22.08. | |||
There was a problem hiding this comment.
Suggested change
| - dask-cuda=22.08. | |
| - dask-cuda=22.08.* |
| @@ -16,7 +16,7 @@ dependencies: | |||
| - rapids-notebook-env=22.02.* | |||
| - rapids-doc-env=22.02.* | |||
| - rmm=22.02.* | |||
| - dask-cuda=22.02.* | |||
| - dask-cuda=22.08. | |||
There was a problem hiding this comment.
Suggested change
| - dask-cuda=22.08. | |
| - dask-cuda=22.08.* |
|
FYI, I am seeing conflicts in rapids-compose that this would solve. It would be nice to get this merged soon -- I know CI issues have been blocking a lot of things. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
This PR complements / supersedes #710 by updating all the RAPIDS packages pinned to the current minor version. This PR also aligns the `update-version.sh` script with the [behavior of the same script from cuML](https://github.com/rapidsai/cuml/blob/branch-22.08/ci/release/update-version.sh), to keep this problem from reoccurring. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: #713
|
This can be closed because #713 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.