Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build.sh to find C++ library by default #697

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 31, 2022

Discussions with the team indicated a general preference for having build.sh default to finding the C++ library by default (and erroring if one is not found) rather than building a new copy of libraft when building raft Python.

@vyasr vyasr added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 31, 2022
@vyasr vyasr self-assigned this May 31, 2022
@vyasr vyasr requested a review from a team as a code owner May 31, 2022 18:56
@vyasr vyasr requested a review from a team as a code owner May 31, 2022 18:56
@github-actions github-actions bot added the gpuCI label May 31, 2022
@cjnolet
Copy link
Member

cjnolet commented May 31, 2022

rather than building a new copy of libcuspatial when building cuspatial Python.

Should this say libraft and raft Python?

@vyasr
Copy link
Contributor Author

vyasr commented May 31, 2022

rather than building a new copy of libcuspatial when building cuspatial Python.

Should this say libraft and raft Python?

Nope. Copy-pasting is always correct ;)
Fixed, thanks for the catch.

@cjnolet
Copy link
Member

cjnolet commented Jun 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 21e8874 into rapidsai:branch-22.06 Jun 1, 2022
@vyasr vyasr deleted the fix/build_sh_cpp_finding branch June 23, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants