Fix SelectionTest: allow different indices when keys are equal. #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
3 - Ready for Review
non-breaking
achirkin
force-pushed
the
fix-selection-tests
branch
from
c06f7ce to
9d7f709
Compare
|
PR looks good. We should probably create an issue for the failing test just so it doesn't fall off our radar. |
cjnolet
approved these changes
May 18, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dists (keys) are the same, different corresponding ids may end up in the selection due to non-deterministic nature of some implementations.
This PR updates the comparison functor in the tests to account for this problem.