Integrate KNN implementation: ivf-flat #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate out cuivfl handle init in separate func
achirkin
added
enhancement
achirkin
added
feature request
Co-authored-by: Tamas Bela Feher <[email protected]>
achirkin
added a commit
to achirkin/cuml
that referenced
this pull request
Jul 21, 2022
Upstream changes: rapidsai/raft#652
cjnolet
approved these changes
Jul 21, 2022
|
rerun tests |
1 similar comment
|
rerun tests |
…n out-of-bounds read of the last entry
…ded in .cpp files as before (in cuml)
|
Thanks Artem for the updates! I had a look at the changes since my last review, and overall it looks good to me. I have some smaller comments (mostly about docs) we can address those in #747. |
achirkin
force-pushed
the
fea-knn-ivf-flat
branch
from
ec23d69 to
8b26750
Compare
|
rerun tests |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
…rim and improve performance for thin matrices (small `n_cols`) (#979) This follows up on a discussion at #652 (comment). The main goal of this PR is to make this helper accessible as a raft primitive. I also used the opportunity to look at the performance of this primitive, and have improved it for: - Thin matrices: less than 32 threads per row with shuffle-based reductions. - Thick matrices: cub-based reduction doing one row per block. Here is an overview of the before/after performance on A100:  Authors: - Louis Sugy (https://github.com/Nyrio) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) - Artem M. Chirkin (https://github.com/achirkin) URL: #979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate a new KNN implementation.