-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Moving cuML prims to RAFT #65
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
We discussed offline that the build changes are new, but can you clarify the other files - are they all exact copies of the recently-updated cuml versions? Or are there additional changes? |
@JohnZed updated the description of the PR to clarify |
rerun tests |
Doesn't look like we're needed for code review, removing @rapidsai/ops-codeowners; add us back if necessary. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward to me! Thanks for making the move.
@JohnZed added the leftover prims, as I mentioned on the call. Reference cuml PR is rapidsai/cuml#3044 |
GIven approvals from both ML and graph, I'll go ahead and merge. Excellent stuff, @divyegala ! |
This PR moves cuml prims to RAFT that will break the circular dependency between libcuml and libcumlprims. The changes made in these files are almost exactly the same as those mirrored by cuML, with only the header paths updated to reflect how raft does it:
#include <common/cudart_utils.h>
became#include <raft/cudart_utils.h>
tests/prims
folder but I took the liberty of dividing it more astests/linalg
,tests/stats
, etc.)In any case, these changes will not affect when we finally delete prims from cuML. Only thing we would need to do there is also update the include path for these prims (files moved), as they are already in the correct formatting and namespaces.