Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes to pairwise distances for cupy integration #643

Merged
merged 11 commits into from
May 11, 2022
Merged

Some fixes to pairwise distances for cupy integration #643

merged 11 commits into from
May 11, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented May 10, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2022
@cjnolet cjnolet self-assigned this May 10, 2022
@cjnolet cjnolet requested a review from a team as a code owner May 10, 2022 22:34
@cjnolet cjnolet mentioned this pull request May 10, 2022
Merged
3 tasks
dantegd
dantegd requested changes May 11, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

python/pylibraft/pylibraft/distance/pairwise_distance.pyx Show resolved Hide resolved
python/pylibraft/pylibraft/distance/pairwise_distance.pyx Outdated Show resolved Hide resolved
python/pylibraft/pylibraft/distance/pairwise_distance.pyx Show resolved Hide resolved
python/pylibraft/pylibraft/distance/pairwise_distance.pyx Outdated Show resolved Hide resolved
@cjnolet cjnolet requested a review from a team as a code owner May 11, 2022 20:48
@github-actions github-actions bot added the cpp label May 11, 2022
@cjnolet
Copy link
Member Author

cjnolet commented May 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d151ed8 into rapidsai:branch-22.06 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees

@cjnolet cjnolet

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @dantegd @divyegala @vinaydes