Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating raft rng host public API and adding docs #636

Merged
merged 12 commits into from
May 5, 2022
Merged

Updating raft rng host public API and adding docs #636

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5674386
Merge branch 'branch-22.04' into branch-22.06
cjnolet Apr 25, 2022
9479613
Merge branch 'branch-22.06' of github.com:rapidsai/raft into branch-2…
cjnolet May 3, 2022
a4d67ca
Updating raft rng public API to add docs and be more explicit
cjnolet May 3, 2022
377e9cc
Fixing compile error
cjnolet May 3, 2022
99a7ae7
Updating tests
cjnolet May 3, 2022
b327692
Final updates
cjnolet May 3, 2022
b576104
Updating rng for raft bench
cjnolet May 4, 2022
ad1586d
Removing empty teardown methods
cjnolet May 4, 2022
a5b38e2
Including handle
cjnolet May 4, 2022
11f8925
Fixing remaining build issues
cjnolet May 4, 2022
61eb416
Updating rng docs to fix ci
cjnolet May 4, 2022
fe5f0ab
Adding old functions back just for compatibility. Will remove them.
cjnolet May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/raft/linalg/detail/rsvd.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ void rsvdFixedRank(const raft::handle_t& handle,
// build random matrix
rmm::device_uvector<math_t> RN(n * l, stream);
raft::random::RngState state{484};
raft::random::normal(state, RN.data(), n * l, math_t(0.0), alpha, stream);
raft::random::normal(handle, state, RN.data(), n * l, math_t(0.0), alpha);

// multiply to get matrix of random samples Y
rmm::device_uvector<math_t> Y(m * l, stream);
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/raft/random/detail/make_blobs.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void generate_labels(IdxT* labels,
cudaStream_t stream)
{
IdxT a, b;
affine_transform_params(r, n_clusters, a, b);
raft::random::affine_transform_params(r, n_clusters, a, b);
auto op = [=] __device__(IdxT * ptr, IdxT idx) {
if (shuffle) { idx = IdxT((a * int64_t(idx)) + b); }
idx %= n_clusters;
Expand Down Expand Up @@ -230,7 +230,7 @@ void make_blobs_caller(DataT* out,
const DataT* _centers;
if (centers == nullptr) {
rand_centers.resize(n_clusters * n_cols, stream);
raft::random::uniform(
detail::uniform(
r, rand_centers.data(), n_clusters * n_cols, center_box_min, center_box_max, stream);
_centers = rand_centers.data();
} else {
Expand Down
Loading