Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullptr as input-indices argument of select_k #618

Merged
merged 3 commits into from
May 17, 2022
Merged

Allow nullptr as input-indices argument of select_k #618

merged 3 commits into from
May 17, 2022

Conversation

achirkin
Copy link
Contributor

Allow passing nullptr as the input-indices-argument of select_k. This would imply the input indices are a range from 0 to input_len - 1 and improve the performance by doing less global memory reads.

Also makes input pointers const as they should be.

@achirkin achirkin requested a review from a team as a code owner April 14, 2022 07:27
@github-actions github-actions bot added the cpp label Apr 14, 2022
@achirkin
Copy link
Contributor Author

Note, the tests are expected to fail until #606 is merged.

@achirkin achirkin added non-breaking Non-breaking change 3 - Ready for Review improvement Improvement / enhancement to an existing function labels Apr 14, 2022
@achirkin achirkin mentioned this pull request Apr 14, 2022
Merged
@achirkin achirkin changed the title Allow nullptr as argument of select_k Allow nullptr as input-indices argument of select_k May 5, 2022
@cjnolet
Copy link
Member

cjnolet commented May 11, 2022

rerun tests

@achirkin achirkin mentioned this pull request May 12, 2022
Merged
tfeher
tfeher approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for the PR, it looks good to me.

@achirkin
Copy link
Contributor Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented May 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 136c77a into rapidsai:branch-22.06 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees

@achirkin achirkin

Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @cjnolet @tfeher