Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMake pinning to allow newer CMake versions #617

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update CMake pinning to allow newer CMake versions #617

merged 1 commit into from
Apr 13, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 13, 2022

CMake 3.23.1 contains the bug fixes that we need to make use of CMake 3.23, so now we can update the pinnings to just avoid 3.23.0.

@vyasr vyasr requested a review from a team as a code owner April 13, 2022 00:20
@vyasr
Copy link
Contributor Author

vyasr commented Apr 13, 2022

I don't have permissions to update labels etc so I'd appreciate if someone would do that for me, thanks!

@cjnolet cjnolet added CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 13, 2022
@cjnolet
Copy link
Member

cjnolet commented Apr 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2f6d247 into rapidsai:branch-22.06 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @cjnolet @robertmaynard @jjacobelli