mdspan/mdarray template functions and utilities

cpp/include/raft/detail/mdarray.hpp

@@ -22,6 +22,7 @@
  */
 #pragma once
 #include <experimental/mdspan>
+#include <raft/cudart_utils.h>
 #include <raft/detail/span.hpp>  // dynamic_extent
 #include <rmm/cuda_stream_view.hpp>
 #include <rmm/device_uvector.hpp>
@@ -58,7 +59,7 @@ class device_reference {
   auto operator=(T const& other) -> device_reference&
   {
     auto* raw = ptr_.get();
-    update_device(raw, &other, 1, stream_);
+    raft::update_device(raw, &other, 1, stream_);
     return *this;
   }
 };

cpp/include/raft/distance/distance.cuh

@@ -258,7 +258,7 @@ void distance(raft::handle_t const& handle,
   RAFT_EXPECTS(x.is_contiguous(), "Input x must be contiguous.");
   RAFT_EXPECTS(y.is_contiguous(), "Input y must be contiguous.");
 
-  auto is_rowmajor = std::is_same<layout, layout_c_contiguous>::value;
+  constexpr auto is_rowmajor = std::is_same_v<layout, layout_c_contiguous>;
 
   distance<distanceType, InType, AccType, OutType, Index_>(x.data(),
                                                            y.data(),
@@ -433,7 +433,7 @@ void pairwise_distance(raft::handle_t const& handle,
   RAFT_EXPECTS(y.is_contiguous(), "Input y must be contiguous.");
   RAFT_EXPECTS(dist.is_contiguous(), "Output must be contiguous.");
 
-  bool rowmajor = x.stride(0) == 0;
+  constexpr auto rowmajor = std::is_same_v<layout, layout_c_contiguous>;
 
   rmm::device_uvector<char> workspace(0, handle.get_stream());