Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling benchmarks building by default. #553

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Disabling benchmarks building by default. #553

merged 1 commit into from
Mar 11, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 11, 2022

This was an oversight because this will break all consumers downstream who are not explicitly turning this off in their get_raft. We should not build these by default (and we should eventually turn off compiling gtests by default as well).

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2022
@cjnolet cjnolet requested a review from a team as a code owner March 11, 2022 21:20
@cjnolet
Copy link
Member Author

cjnolet commented Mar 11, 2022

@gpucibot merge

@cjnolet
Copy link
Member Author

cjnolet commented Mar 11, 2022

rerun tests

@rapids-bot rapids-bot bot merged commit ecfbce8 into rapidsai:branch-22.04 Mar 11, 2022
@seunghwak seunghwak mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @seunghwak