Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks #549

Merged
merged 10 commits into from
Mar 11, 2022
Merged

Add benchmarks #549

merged 10 commits into from
Mar 11, 2022

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Mar 9, 2022

Copied the benchmarking setup and one simple benchmark (as an example) from cuml.

@achirkin achirkin requested review from a team as code owners March 9, 2022 08:43
@achirkin achirkin added feature request New feature or request non-breaking Non-breaking change labels Mar 9, 2022
cjnolet
cjnolet requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for getting a start on moving this over! Mostly trivial things like updating docs / build.sh

cpp/bench/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/bench/common/benchmark.hpp Outdated Show resolved Hide resolved
cpp/bench/linalg/reduce.cu Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Show resolved Hide resolved
@achirkin achirkin requested a review from cjnolet March 10, 2022 09:55
@achirkin achirkin requested a review from a team as a code owner March 10, 2022 10:02
@github-actions github-actions bot added the gpuCI label Mar 10, 2022
@achirkin achirkin mentioned this pull request Mar 10, 2022
Merged
@achirkin achirkin mentioned this pull request Mar 11, 2022
Closed
cjnolet
cjnolet approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge pending ops review.

@cjnolet
Copy link
Member

cjnolet commented Mar 11, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dcc6509 into rapidsai:branch-22.04 Mar 11, 2022
@achirkin achirkin deleted the fea-gbench branch March 31, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@achirkin achirkin

Labels
3 - Ready for Review CMake cpp feature request New feature or request gpuCI non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @cjnolet @jjacobelli