Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include thrust/sort.h in ball_cover.cuh #526

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Include thrust/sort.h in ball_cover.cuh #526

merged 4 commits into from
Feb 23, 2022

Conversation

akifcorduk
Copy link
Member

New thrust release (11.6) has removed some unnecessary header includes. In order for raft to build, we need to include thrust/sort.h in ball_cover.cuh.

@akifcorduk akifcorduk requested a review from a team as a code owner February 23, 2022 15:32
@github-actions github-actions bot added the cpp label Feb 23, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2022
cjnolet
cjnolet approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @akifcorduk for fixing this!

@cjnolet
Copy link
Member

cjnolet commented Feb 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0bbdd4d into rapidsai:branch-22.04 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akifcorduk @cjnolet