Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft-config is idempotent no matter RAFT_COMPILE_LIBRARIES value #516

Merged

Conversation

robertmaynard
Copy link
Contributor

This allows us to correctly handle raft with and without compiled libraries.

This allows us to correctly handle raft with and without compiled
libraries.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change CMake labels Feb 18, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner February 18, 2022 19:45
@github-actions github-actions bot added the cpp label Feb 18, 2022
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Feb 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 98d60db into rapidsai:branch-22.04 Feb 18, 2022
@robertmaynard robertmaynard deleted the raft_idempotent-config branch February 28, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants