Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve row-major meanvar kernel via minimizing atomicCAS locks #489

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Feb 7, 2022

Map the row-major kernel grid onto the data more efficiently. In particular, make sure there is only one atomicCAS lock per thread block to avoid any possible deadlocks caused by branch divergence within the critical section.

@achirkin achirkin added bug Something isn't working non-breaking Non-breaking change labels Feb 7, 2022
@github-actions github-actions bot added the cpp label Feb 7, 2022
@achirkin achirkin added the 2 - In Progress Currenty a work in progress label Feb 7, 2022
@achirkin
Copy link
Contributor Author

achirkin commented Feb 7, 2022

rerun tests

@achirkin achirkin changed the title [WIP] Improve row-major meanvar kernel via minimizing atomicCAS locks Improve row-major meanvar kernel via minimizing atomicCAS locks Feb 7, 2022
@achirkin achirkin marked this pull request as ready for review February 7, 2022 11:51
@achirkin achirkin requested a review from a team as a code owner February 7, 2022 11:51
@achirkin achirkin added 3 - Ready for Review and removed 2 - In Progress Currenty a work in progress labels Feb 7, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 7, 2022

rerun tests

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending successful CI

@cjnolet
Copy link
Member

cjnolet commented Feb 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 57a23f3 into rapidsai:branch-22.04 Feb 7, 2022
@achirkin achirkin deleted the fix-meanvar-rowmajor branch February 7, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants