Hiding implementation details for lap, clustering, spectral, and label #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maining_public_api_bits
update lap, spectral, cluster, and label packages
cjnolet
added
3 - Ready for Review
breaking
|
I realize I have a lot of copyrights to update :-) |
divyegala
approved these changes
Feb 1, 2022
| @@ -60,7 +62,12 @@ TEST(Raft, ModularitySolvers) | |||
| using value_type = double; | |||
|
|
|||
| handle_t h; | |||
| ASSERT_EQ(0, h.get_device()); | |||
| ASSERT_EQ(0, | |||
There was a problem hiding this comment.
Did something go wrong here with the formatting?
| @@ -34,7 +36,12 @@ TEST(Raft, EigenSolvers) | |||
| using value_type = double; | |||
|
|
|||
| handle_t h; | |||
| ASSERT_EQ(0, h.get_device()); | |||
| ASSERT_EQ(0, | |||
| @@ -75,7 +82,12 @@ TEST(Raft, SpectralSolvers) | |||
| using value_type = double; | |||
|
|
|||
| handle_t h; | |||
| ASSERT_EQ(0, h.get_device()); | |||
| ASSERT_EQ(0, | |||
There was a problem hiding this comment.
Ooh, this one is strange. I'm not sure why clang-format did this.
|
rerun tests |
…maining_public_api_bits
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also managed to remove the raft host/device buffers in the process