Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding destructor for std comms and using nccl allreduce for barrier in mpi comms #473

Merged
merged 11 commits into from
Feb 9, 2022
Merged

Adding destructor for std comms and using nccl allreduce for barrier in mpi comms #473

merged 11 commits into from
Feb 9, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 1, 2022

Closes #281

@cjnolet cjnolet added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Feb 1, 2022
@cjnolet cjnolet requested review from a team as code owners February 1, 2022 16:12
@github-actions github-actions bot added the cpp label Feb 1, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 1, 2022

@seunghwak, it would be great to your approval on this one since you are familiar w/ the guts of the comms.

@cjnolet cjnolet requested a review from a team as a code owner February 2, 2022 19:26
@cjnolet cjnolet changed the title Adding destructor for std comms to clear out requests_in_flight and free_requests Adding destructor for std comms and using nccl allreduce for barrier in mpi comms Feb 2, 2022
@cjnolet cjnolet removed request for a team February 2, 2022 20:22
@cjnolet cjnolet added breaking Breaking change and removed non-breaking Non-breaking change labels Feb 2, 2022
seunghwak
seunghwak approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have several suggestions about cosmetic issues, but this looks great to me in general.

Approving to not be a bottleneck (and all my complaints really don't affect program behavior).

cpp/include/raft/comms/detail/mpi_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/mpi_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/mpi_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/mpi_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/std_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/std_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/detail/std_comms.hpp Outdated Show resolved Hide resolved
cpp/include/raft/comms/mpi_comms.hpp Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6963de9 into rapidsai:branch-22.04 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review breaking Breaking change bug Something isn't working cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] std comms to clean up contents of requests_in_flight upon failure
2 participants
@cjnolet @seunghwak