Public apis for remainder of matrix and stats #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
non-breaking
cjnolet
approved these changes
Jan 10, 2022
cjnolet
requested changes
Jan 11, 2022
There was a problem hiding this comment.
These seem like harmless changes and shouldn't affect the public API, however when I attempted to build cuml w/ the changes, I get the following compile error:
/share/workspace/rapids_projects/raft/cpp/include/raft/matrix/matrix.hpp: In instantiation of ‘m_t raft::matrix::getL2Norm(const raft::handle_t&, m_t*, idx_t, cudaStream_t) [with m_t = float; idx_t = int; cudaStream_t = CUstream_st*]’:
/share/workspace/rapids_projects/raft/cpp/include/raft/linalg/svd.cuh:366:33: required from ‘bool raft::linalg::evaluateSVDByL2Norm(const raft::handle_t&, math_t*, math_t*, math_t*, math_t*, int, int, int, math_t, cudaStream_t) [with math_t = float; cudaStream_t = CUstream_st*]’
/share/workspace/rapids_projects/cuml/cpp/test/prims/rsvd.cu:269:289: required from here
/share/workspace/rapids_projects/raft/cpp/include/raft/matrix/matrix.hpp:224:1: error: no return statement in function returning non-void [-Werror=return-type]
224 | }
| ^
/share/workspace/rapids_projects/raft/cpp/include/raft/matrix/matrix.hpp: In instantiation of ‘m_t raft::matrix::getL2Norm(const raft::handle_t&, m_t*, idx_t, cudaStream_t) [with m_t = double; idx_t = int; cudaStream_t = CUstream_st*]’:
/share/workspace/rapids_projects/raft/cpp/include/raft/linalg/svd.cuh:366:33: required from ‘bool raft::linalg::evaluateSVDByL2Norm(const raft::handle_t&, math_t*, math_t*, math_t*, math_t*, int, int, int, math_t, cudaStream_t) [with math_t = double; cudaStream_t = CUstream_st*]’
/share/workspace/rapids_projects/cuml/cpp/test/prims/rsvd.cu:286:289: required from here
/share/workspace/rapids_projects/raft/cpp/include/raft/matrix/matrix.hpp:224:1: error: no return statement in function returning non-void [-Werror=return-type]Can you open a PR to cuml to test these changes? (Hopefully we won't have to do this for too much longer).
|
I verified locally that cuml builds successfully w/ these changes |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, when I created public APIs for
matrixandstatspackages, I let implementation be in the public API if it was a simple thrust call or a call to another RAFT API. However, after further discussion, it's cleaner consistency to have the implementation always be indetail. I also added missing docs in this PR.