[REVIEW] [FEA] error macros: determining buffer size instead of fixed 2048 chars #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasKohl
added
feature request
cjnolet
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
The changes look great. It would also be great if we could find a way to test this through our automated gtests.
I ran all tests (which use these macros extensively) as well as tested without CUDA driver to see that output looks as expected.
Was this tested in cuml as well?
|
That's a good point and no, unfortunately I didn't test with cuml. I can do that after vacation. Should I still add specific tests for these changes as well? |
|
A couple very trivial gtest cases would be great. The goal is to get to a point where we can modify RAFT without having to test whether all the clients break. |
|
@cjnolet I did add specific tests for this, checking that the error messages are as expected. |
BradReesWork
approved these changes
Jan 11, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determining buffer size for error macros instead of using fixed size of 2048 bytes.
I ran all tests (which use these macros extensively) as well as tested without CUDA driver to see that output looks as expected.
Closes #419.