Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Disabling expanded fused l2 knn to unblock cuml CI #404

Merged
merged 3 commits into from
Dec 2, 2021
Merged

[REVIEW] Disabling expanded fused l2 knn to unblock cuml CI #404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e603877
Disabling fused l2 knn for now.
cjnolet Dec 2, 2021
87f8af6
fixing style
cjnolet Dec 2, 2021
1c818ff
Only disabling expanded variant
cjnolet Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/include/raft/spatial/knn/detail/knn_brute_force_faiss.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@ void brute_force_knn_impl(

cudaStream_t stream = raft::select_stream(userStream, internalStreams, n_int_streams, i);

// TODO: Enable this once we figure out why it's causing pytest failures in cuml.
if (k <= 64 && rowMajorQuery == rowMajorIndex && rowMajorQuery == true &&
(metric == raft::distance::DistanceType::L2Unexpanded ||
metric == raft::distance::DistanceType::L2SqrtUnexpanded ||
metric == raft::distance::DistanceType::L2Expanded ||
metric == raft::distance::DistanceType::L2SqrtExpanded)) {
metric == raft::distance::DistanceType::L2SqrtUnexpanded //||
// metric == raft::distance::DistanceType::L2Expanded ||
// metric == raft::distance::DistanceType::L2SqrtExpanded)
)) {
fusedL2Knn(D,
out_i_ptr,
out_d_ptr,
Expand Down