-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Hiding implementation details for distance primitives (dense + sparse) #344
Merged
rapids-bot
merged 23 commits into
rapidsai:branch-21.12
from
cjnolet:imp-2112-public_api
Oct 22, 2021
Merged
[REVIEW] Hiding implementation details for distance primitives (dense + sparse) #344
rapids-bot
merged 23 commits into
rapidsai:branch-21.12
from
cjnolet:imp-2112-public_api
Oct 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
2 - In Progress
Currenty a work in progress
labels
Sep 30, 2021
cjnolet
changed the title
Hiding implementation details for distance primitives (dense + sparse)
[WIP] Hiding implementation details for distance primitives (dense + sparse)
Sep 30, 2021
cjnolet
changed the title
[WIP] Hiding implementation details for distance primitives (dense + sparse)
[REVIEW] Hiding implementation details for distance primitives (dense + sparse)
Oct 1, 2021
cjnolet
added
3 - Ready for Review
and removed
2 - In Progress
Currenty a work in progress
labels
Oct 1, 2021
divyegala
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, pre-approving! Just pointing out a few more detail::
calls that aren't needed that I think got looked over in your latest commit
rerun tests |
dantegd
approved these changes
Oct 22, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
cpp
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.