Update with rapids cmake new features #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of early terminating before calling `rapids_cpm_find` make sure the target is part of `GLOBAL_TARGETS` and rapids-cmake will do the logic for you. The is important as it will still allow rapids-cmake to record the dependency and generate proper `<project>-config` files with all correct dependencies.
dantegd
added
improvement
dantegd
requested changes
Aug 28, 2021
Remove pinned raft version
dantegd
approved these changes
Sep 9, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines some general CMake style cleanup and brings new rapids-cmake features to RAFT including:
rapids_cmake_install_lib_dirto make sure we install raft correctly on non-debain based distro's ( lib64 ), while also handling conda installation requirements ( always lib no matter the distro )rapids_cpmpre-configured pacakgesrapids_cpm_findsince a better solution now exists ( [BUG]rapids_cpm_findisn't as invariant as one would expect rapids-cmake#49 )