Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .clang-format to be consistent with all other RAPIDS repos #300

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Update .clang-format to be consistent with all other RAPIDS repos #300

merged 6 commits into from
Nov 25, 2021

Conversation

codereport
Copy link
Contributor

All RAPIDS repos share the same .clang-format config file except Raft. This PR fixes that.

@codereport codereport requested review from a team as code owners July 27, 2021 16:48
@github-actions github-actions bot added the cpp label Jul 27, 2021
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 27, 2021
@cjnolet cjnolet changed the base branch from branch-21.10 to branch-21.12 October 12, 2021 18:40
@cjnolet
Copy link
Member

cjnolet commented Oct 12, 2021

I think it would be great to keep the formatting rules for raft in sync w/ the other RAPIDS repos. @codereport, are you hoping to get this merged for 21.12?

@codereport
Copy link
Contributor Author

I think it would be great to keep the formatting rules for raft in sync w/ the other RAPIDS repos. @codereport, are you hoping to get this merged for 21.12?

Oh wow, I totally forgot about this PR. At some point I asked for reviews on slack but clearly didn't get any. Let me update this PR and retarget it on 21.12 and then reping folks on slack. Thanks!

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@codereport
Revert "Formatting changes"
31bf93e 
This reverts commit cc03dba.
@github-actions github-actions bot removed the cpp label Nov 24, 2021
@codereport codereport changed the base branch from branch-21.12 to branch-22.02 November 24, 2021 22:59
@codereport codereport requested a review from a team as a code owner November 24, 2021 22:59
@github-actions github-actions bot removed the CMake label Nov 24, 2021
cjnolet
cjnolet approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Nov 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ca4f36a into rapidsai:branch-22.02 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function inactive-30d non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codereport @cjnolet @jjacobelli @BradReesWork @dantegd