[REVIEW] Move FAISS ANN wrappers to RAFT #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
feature request
viclafargue
approved these changes
Jun 9, 2021
dantegd
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
lgtm except it's missing an update for the header name change:
In file included from ../test/sparse/knn.cu:22:
../include/raft/sparse/selection/knn.cuh:36:10: fatal error: raft/spatial/knn/detail/brute_force_knn.cuh: No such file or directory
36 | #include <raft/spatial/knn/detail/brute_force_knn.cuh>
|
BradReesWork
approved these changes
Jun 9, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jun 16, 2021
This accompanies the RAFT PR: rapidsai/raft#265 Closes #3954 Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) URL: #3963
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This accompanies the RAFT PR: rapidsai/raft#265 Closes rapidsai#3954 Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.