Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nested include in destination of install headers to avoid docker permission issues #263

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Use nested include in destination of install headers to avoid docker permission issues #263

merged 2 commits into from
Jun 18, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 8, 2021

No description provided.

@dantegd dantegd added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Jun 8, 2021
@dantegd dantegd requested a review from divyegala as a code owner June 8, 2021 20:39
@robertmaynard
Copy link
Contributor

This will stop raft.hpp from being installed as it isn't in the raft subdirectory

divyegala
divyegala approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantegd dantegd changed the base branch from branch-21.06 to branch-21.08 June 17, 2021 04:09
@dantegd
Copy link
Member Author

dantegd commented Jun 18, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 806b7fa into rapidsai:branch-21.08 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @robertmaynard @divyegala